Skip to content

Conversation

@jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Oct 27, 2020

grafik
solves: #2800
This is only a 1st try, I don't know how hard it is do finish it.

Questions/Todo

  • change the chat
  • post quoted msg
  • send new msg
  • use another icon?

Signed-off-by: Jakob Röhrl <[email protected]>
@jakobroehrl jakobroehrl changed the title Private reply WIP: Private reply Oct 27, 2020
@jakobroehrl jakobroehrl linked an issue Oct 27, 2020 that may be closed by this pull request
@nickvergessen
Copy link
Member

What should happen, if the user clicks on the "Reply private" Button? Change the chat and show the quote there? If yes, how can I change the chat?

The thing is we prohibit this. You can not quote messages from chat A in chat B, to avoid leaking of messages when people are removed from chats etc. So my suggestion (same as for forward) would be to just copy the original text message with a > in front to the input, after changing to the one-to-one conversation:

> What should happen, if the user clicks on the "Reply private" Button? Change the chat and show the quote there? If yes, how can I change the chat?

But switching is not that easy, because you might not have the one-to-one chat before, so you first need to create it or rejoin it in case you left it. But all this can be done with a call to

*/
const createOneToOneConversation = async function(userId) {
try {
const response = await axios.post(generateOcsUrl('apps/spreed/api/v2', 2) + `room`, { roomType: CONVERSATION.TYPE.ONE_TO_ONE, invite: userId })
return response
} catch (error) {
console.debug('Error creating new one to one conversation: ', error)
}
}

From that function you should always get back the room data, so you can afterwards trigger a join for that token, but @ma12-co might be better in telling you where that code is

@jakobroehrl
Copy link
Contributor Author

@jancborchardt Should I use another icon?

@jakobroehrl jakobroehrl added this to the 💚 Next Major (21) milestone Oct 28, 2020
@jakobroehrl jakobroehrl self-assigned this Oct 29, 2020
@nickvergessen nickvergessen marked this pull request as draft December 16, 2020 10:26
@nickvergessen
Copy link
Member

Converting to draft for easier sorting.

@nickvergessen
Copy link
Member

@jancborchardt Should I use another icon?

🏓

@jakobroehrl
Copy link
Contributor Author

@nickvergessen
When could we pick up the work here?
see: #4477 (comment)

@jakobroehrl
Copy link
Contributor Author

see: #4855

@nickvergessen nickvergessen deleted the enh/privateReply branch July 27, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reply-privately feature

3 participants