Private reply without quote #4855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobroehrl
force-pushed
the
enh/privateReply2
branch
from
ced63e1 to
fc155d1
Compare
Member
As said before, this will not work and I will not make it work. We will not be able to show messages of another chat 1 in the private chat 2. Checking if users have/retain access and so on is way to difficult. That's why I posted it in #4477 (comment) If you reply, we need to copy it somehow into the chat input, either with: or or something. |
Contributor
Sound good to me. This is e.g. how Whatsapp handles this. Of course it would need to display the whole message in quotes in this case and not a shortened one. |
jakobroehrl
force-pushed
the
enh/privateReply2
branch
5 times, most recently
from
2c3d8db to
1ddc63f
Compare
Contributor
Author
|
@nickvergessen |
Signed-off-by: Jakob Röhrl <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
enh/privateReply2
branch
from
1ddc63f to
c4769a2
Compare
nickvergessen
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jakob Röhrl [email protected]
solves: #2800
works only in group chats, not for guest and my own messages
continuation of #4477