Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
0687119
Revert "Temporary disable SIP UI parts"
nickvergessen Oct 30, 2020
5437eb4
Make the version checks future proof
nickvergessen Oct 30, 2020
1bc3284
Add a comment why the last comment is not included for sip
nickvergessen Oct 30, 2020
25d8bac
Use $this->request to access header and add docs about the return value
nickvergessen Oct 30, 2020
ad0032a
Prevent concurrent promotion/demotion requests to revert by accident
nickvergessen Oct 30, 2020
cebc640
Add a comment about the session
nickvergessen Oct 30, 2020
89f3f35
Fix copyright year
nickvergessen Oct 30, 2020
459858a
Introduce constants for the actor types
nickvergessen Oct 30, 2020
384b4ba
Add a comment about the non-0 exit code of the talk:active-call command
nickvergessen Oct 30, 2020
3f6fe4f
Add method to get room by actorId / actorType.
fancycode Oct 30, 2020
d0e799b
Get room by actorId / actorType if given in request.
fancycode Oct 30, 2020
f3e6e56
Get the participant by actor
nickvergessen Oct 30, 2020
d5dbdeb
Store the session given by the HPB for the actor
nickvergessen Oct 30, 2020
59133fe
Increase the length of the session id column
nickvergessen Oct 30, 2020
12d1bf1
Fix CS and psalm
nickvergessen Nov 2, 2020
92efefe
Only generate a PIN and send it when configured
nickvergessen Nov 2, 2020
e65bee6
Only delete guests without a PIN
nickvergessen Nov 2, 2020
1c0c893
Only allow enabling SIP when the user can enable it
nickvergessen Nov 2, 2020
02aa765
Only delete users that are guests as actor type not participant type
nickvergessen Nov 3, 2020
f4d0368
Generate a PIN for users when they join a room with SIP enabled
nickvergessen Nov 3, 2020
10bda4f
Show pins to moderators
nickvergessen Nov 3, 2020
84b7597
Use the call flag when it was given by the HPB server
nickvergessen Nov 3, 2020
23aab9e
Show the dial-in info in the sidebar
nickvergessen Nov 3, 2020
758048f
Don't expose SIP data when SIP is not configured anymore
nickvergessen Nov 3, 2020
2b7ce7a
Ignore the exception that is unknown
nickvergessen Nov 3, 2020
8aa3e76
Add the participant to the join/start call message generation
nickvergessen Nov 4, 2020
6902bdf
Add missing alias when deleting a room in the background job
nickvergessen Nov 4, 2020
b05a602
The session object is modified nowadays so it's always disconnected i…
nickvergessen Nov 4, 2020
f9813a5
Dispatch leave call events when the user was in call while leaving th…
nickvergessen Nov 4, 2020
8687b5c
All parameters are lowercase
nickvergessen Nov 4, 2020
a22a889
Don't preload the user so we load it with the session later on
nickvergessen Nov 4, 2020
d708bc5
Load the participant by session as loading by actor is prefetched onl…
nickvergessen Nov 4, 2020
51c1afc
Add constants for SIP flags and pass on the event
nickvergessen Nov 11, 2020
954d960
Don't show the SIP connection as guest
nickvergessen Nov 11, 2020
2b052e8
Also load the session information when we load an attendee
nickvergessen Nov 11, 2020
1b4c42e
When the HPB provided a session id only join/leave with that session
nickvergessen Nov 13, 2020
8e03129
Update baseline
nickvergessen Nov 16, 2020
18e6072
Refresh the peer list and take the display name from there
nickvergessen Nov 16, 2020
c0a94ed
Use a new VideoBackground component when we get a userId
nickvergessen Nov 16, 2020
23a778b
Fix baseline
nickvergessen Nov 17, 2020
df69c33
Also check the room token when suggesting if SIP can be enabled
nickvergessen Nov 17, 2020
a655825
Simplify getting the participant
nickvergessen Nov 17, 2020
c287c0f
Update baseline
nickvergessen Nov 17, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase the length of the session id column
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
nickvergessen committed Nov 26, 2020
commit 59133fe982c0c391152332e0da8ba69f70cce6ae
2 changes: 1 addition & 1 deletion appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ And in the works for the [coming versions](https://github.com/nextcloud/spreed/m

]]></description>

<version>11.0.0-dev.6</version>
<version>11.0.0-dev.7</version>
<licence>agpl</licence>

<author>Daniel Calviño Sánchez</author>
Expand Down
2 changes: 1 addition & 1 deletion lib/Migration/Version10000Date20201015134000.php
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt
// Unique key to avoid duplication issues
$table->addColumn('session_id', Type::STRING, [
'notnull' => true,
'length' => 255,
'length' => 512,
]);

$table->addColumn('in_call', Type::INTEGER, [
Expand Down
62 changes: 62 additions & 0 deletions lib/Migration/Version10000Date20201015150000.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<?php

declare(strict_types=1);
/**
* @copyright Copyright (c) 2020, Joas Schilling <[email protected]>
*
* @author Joas Schilling <[email protected]>
*
* @license GNU AGPL version 3 or any later version
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License as
* published by the Free Software Foundation, either version 3 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*
*/

namespace OCA\Talk\Migration;

use Closure;
use OCP\DB\ISchemaWrapper;
use OCP\Migration\IOutput;
use OCP\Migration\SimpleMigrationStep;

/**
* The HPB is generating sessions longer than 255 chars. So we update the length
* But the install migration was fixed, so this only does something on update.
*/
class Version10000Date20201015150000 extends SimpleMigrationStep {

/**
* @param IOutput $output
* @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
* @param array $options
* @return null|ISchemaWrapper
*/
public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
/** @var ISchemaWrapper $schema */
$schema = $schemaClosure();

if ($schema->hasTable('talk_sessions')) {
$table = $schema->getTable('talk_sessions');

$column = $table->getColumn('session_id');

if ($column->getLength() !== 512) {
$column->setLength(512);
return $schema;
}
}

return null;
}
}