Fix message list scroll container in sidebar #4529
Conversation
When embedded into the right sidebar, the scrolling is achieved by a parent element instead of the MessagesList itself. To be able to listen to and control the scrolling, now a reference to the scroll container is passed in. Signed-off-by: Vincent Petry <[email protected]>
|
this took me a while as I first tried to use computed properties but bumped against this issue: https://stackoverflow.com/questions/43531755/using-refs-in-a-computed-property One should not use "$refs" in computed properties as it might not be defined initially, and also $refs is not reactive so even if it becomes defined the computed property won't re-evaluate. Hence I've used watchers instead. |
|
back to draft as I'm going to investigate the size issue #4527 (comment) and there's a slight risk that I might need to reshuffle the containers to make it work 🙈 |
|
I knew it... to fix the container I have to set height: 1px on it as per https://stackoverflow.com/a/21836870
but doing so breaks the scrolling events and measurements on that element. needs further research |
|
I found a simpler fix that fixes both... #4530 |
nickvergessen
deleted the
bugfix/4527/fix-chat-sidebar-scroll-container
branch
When embedded into the right sidebar, the scrolling is achieved by a
parent element instead of the MessagesList itself.
To be able to listen to and control the scrolling, now a reference to
the scroll container is passed in.
Fixes #4527
This issue was due to the recent changes in scrollbar containment in the sidebar.
Manual tests
Scrolling
Layout