Skip to content

Fix sidebar chat scroll container + size #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Nov 12, 2020
Merged

Fix sidebar chat scroll container + size #4530

nickvergessen merged 1 commit into from
Nov 12, 2020
+2 −0

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Nov 4, 2020

This brings back the scrolling behavior to the "scroller" element, so
that the matching logic can rely on it.

This also makes the message form align to the bottom whenever there are
not enough chat messages to expand the container vertically.

Fixes #4527
Obsoletes #4529

@PVince81 PVince81 added bug feature: chat 💬 Chat and system messages labels Nov 4, 2020
@PVince81 PVince81 added this to the 💚 Next Major (21) milestone Nov 4, 2020
@PVince81 PVince81 self-assigned this Nov 4, 2020
This was referenced Nov 4, 2020
Closed
Closed
@PVince81
Copy link
Member Author

PVince81 commented Nov 4, 2020

annnd it breaks the main view... I'll limit it to the sidebar mode...

@PVince81
Fix sidebar chat scroll container + size
7edff3f 
This brings back the scrolling behavior to the "scroller" element, so
that the matching logic can rely on it.

This also makes the message form align to the bottom whenever there are
not enough chat messages to expand the container vertically.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the bugfix/4527/fix-chat-sidebar-scroll-layout branch from 02a84df to 7edff3f Compare November 4, 2020 15:36
@PVince81
Copy link
Member Author

PVince81 commented Nov 4, 2020

actually adding width: 100% fixes that

having styles that work everywhere is quite the sport...

@PVince81 PVince81 requested a review from danxuliu November 4, 2020 15:38
@nickvergessen nickvergessen merged commit a6c1027 into master Nov 12, 2020
@nickvergessen nickvergessen deleted the bugfix/4527/fix-chat-sidebar-scroll-layout branch November 12, 2020 09:13
@danxuliu
Copy link
Member

danxuliu commented Nov 13, 2020

@PVince81 This seems to break the style in the Files app sidebar (now the chat scrolls over the Start call button). Could you take a look (and raise your beloved issues if you want :-P )? Thanks!

@PVince81
Copy link
Member Author

PVince81 commented Nov 13, 2020

yeah... sidebar scroll is always tricky... I think I saw this coming during a quick test while the sidebar was still in PR form.
I'll add a background to make it look fine.

@PVince81 PVince81 mentioned this pull request Nov 13, 2020
Merged
@PVince81
Copy link
Member Author

PVince81 commented Nov 13, 2020

@danxuliu fix is here: #4590

@danxuliu
Copy link
Member

danxuliu commented Nov 18, 2020

@PVince81 Another two regressions from this pull request (still valid in current master):

Scenario 1

  • Open the Files app
  • Share a file by link
  • Set a password
  • Enable video verification
  • Copy the link
  • In a private window, open the link
  • Request password

The layout of the video verification sidebar is broken.

Scenario 2

  • Open the Files app
  • Share a file by link
  • Copy the link
  • In a private window, open the link
  • Join the conversation

The layout of the sidebar is broken.

@PVince81
Copy link
Member Author

PVince81 commented Nov 18, 2020

@PVince81 Another two regressions from this pull request (still valid in current master):

Scenario 1

* Open the Files app

* Share a file by link

* Set a password

* Enable video verification

* Copy the link

* In a private window, open the link

* Request password

The layout of the video verification sidebar is broken.

Scenario 2

* Open the Files app

* Share a file by link

* Copy the link

* In a private window, open the link

* Join the conversation

The layout of the sidebar is broken.

new ticket please, otherwise this gets lost quickly

@PVince81 PVince81 mentioned this pull request Nov 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@PVince81 PVince81

Labels

3. to review bug feature: chat 💬 Chat and system messages

Projects

None yet

Milestone

v11.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

Scroll to bottom button is missing

4 participants

@PVince81 @danxuliu @nickvergessen