Skip to content

Fix mime icon and failed icon height #4537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 3 commits into from
Nov 6, 2020
Merged

Fix mime icon and failed icon height #4537

PVince81 merged 3 commits into from
Nov 6, 2020

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Nov 5, 2020 •
edited by danxuliu
Loading

Follow up to #4472

Description

  • refactor preview type handling to make it more accessible instead of having to rely on multiple flags
  • detect mime icon and failed cases and adjust the icon height accordingly

Testing

Steps

  1. Create a text file "corrupt-image.txt" with some contents and rename to "corrupt-image.jpg"
  2. Create another text file "data.dat"
  3. Upload both to a converstion

Before the fix

Tiny mime type icon and tiny failed icon

After the fix

Bigger mime type icons

@PVince81 PVince81 added bug feature: chat 💬 Chat and system messages labels Nov 5, 2020
@PVince81 PVince81 added this to the 💚 Next Major (21) milestone Nov 5, 2020
@PVince81 PVince81 self-assigned this Nov 5, 2020
@PVince81 PVince81 mentioned this pull request Nov 5, 2020
Merged
@PVince81
Expose file preview type as single value
fd461aa 
Implement previewType in file preview that specifies what kind of
preview is being displayed.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Fix mime type icon height
98e9d48 
Whenever a mime type icon is displayed, apply min-height to make it look
bigger.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the bugfix/noid/preview-mimeicon-height branch from b6204f6 to 98e9d48 Compare November 5, 2020 10:43
@PVince81 PVince81 mentioned this pull request Nov 5, 2020
Merged
2 tasks
danxuliu
danxuliu reviewed Nov 6, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

But please check the comments :-)

@PVince81 PVince81 requested a review from danxuliu November 6, 2020 08:33
danxuliu
danxuliu approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@PVince81 PVince81 merged commit 3af57c8 into master Nov 6, 2020
@PVince81 PVince81 deleted the bugfix/noid/preview-mimeicon-height branch November 6, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu danxuliu approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@PVince81 PVince81

Labels

4. to release bug feature: chat 💬 Chat and system messages

Projects

None yet

Milestone

v11.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81 @danxuliu