-
Notifications
You must be signed in to change notification settings - Fork 509
Add play button on top of video or gif previews #4538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7732801 to
35f5df9
Compare
|
rebased and conflicts solved |
35f5df9 to
9d0c722
Compare
|
Shouldn't we just autoplay them muted when they're in the viewport? Don't gifs already autoplay? |
GIFs only autoplay when they have a small size, by default less then 3 MB. For videos, we render the preview by default so no autoplay. The performance might be bad if we autoplay many videos within the thread, might need to do that only when they become visible or on hover. But I'd see this as a separate task/attempt. As for playing the videos directly, this is more involved as we need to have the HTML 5 video player in place, ideally the same like the viewer app. Or maybe have a way for the viewer app to inject its player there. This is all more involved and would rather attempt this much later... |
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All righty then :)
Whenever a video or GIF as a preview displayed, add a play icon to make it clear that it's a video and that a viewer is available for playing it Adds an image container to be able to center the play button. Signed-off-by: Vincent Petry <[email protected]>
9d0c722 to
7da0748
Compare
|
rebased and conflict solved, retested |

Description
Whenever a video preview of GIF preview (not direct) is displayed, add a play button to make it clear that what is here is not a picture but a playable video.
Testing
When testing, make sure to have the
Moviepreview provider enabled.Todos