Skip to content

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Nov 5, 2020

Description

Whenever a video preview of GIF preview (not direct) is displayed, add a play button to make it clear that what is here is not a picture but a playable video.

2020-11-05 11-48-28 mkv

Testing

When testing, make sure to have the Movie preview provider enabled.

Todos

@PVince81 PVince81 added enhancement feature: chat 💬 Chat and system messages labels Nov 5, 2020
@PVince81 PVince81 added this to the 💚 Next Major (21) milestone Nov 5, 2020
@PVince81 PVince81 self-assigned this Nov 5, 2020
@PVince81 PVince81 force-pushed the enh/noid/preview-play-button branch from 7732801 to 35f5df9 Compare November 6, 2020 13:09
@PVince81
Copy link
Member Author

PVince81 commented Nov 6, 2020

rebased and conflicts solved

@PVince81 PVince81 force-pushed the enh/noid/preview-play-button branch from 35f5df9 to 9d0c722 Compare November 6, 2020 13:20
@PVince81
Copy link
Member Author

PVince81 commented Nov 6, 2020

I managed to improve the button style:
image

@PVince81 PVince81 marked this pull request as ready for review November 6, 2020 13:21
@marcoambrosini
Copy link
Member

Shouldn't we just autoplay them muted when they're in the viewport? Don't gifs already autoplay?

@PVince81
Copy link
Member Author

Shouldn't we just autoplay them muted when they're in the viewport? Don't gifs already autoplay?

GIFs only autoplay when they have a small size, by default less then 3 MB.

For videos, we render the preview by default so no autoplay. The performance might be bad if we autoplay many videos within the thread, might need to do that only when they become visible or on hover. But I'd see this as a separate task/attempt.

As for playing the videos directly, this is more involved as we need to have the HTML 5 video player in place, ideally the same like the viewer app. Or maybe have a way for the viewer app to inject its player there. This is all more involved and would rather attempt this much later...

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All righty then :)

Whenever a video or GIF as a preview displayed, add a play icon to make
it clear that it's a video and that a viewer is available for playing
it

Adds an image container to be able to center the play button.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the enh/noid/preview-play-button branch from 9d0c722 to 7da0748 Compare November 12, 2020 09:08
@PVince81
Copy link
Member Author

rebased and conflict solved, retested

@PVince81 PVince81 merged commit 7508a88 into master Nov 12, 2020
@PVince81 PVince81 deleted the enh/noid/preview-play-button branch November 12, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants