Skip to content

Add play button on top of video or gif previews #4538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Nov 12, 2020
Merged

Add play button on top of video or gif previews #4538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 61 additions & 10 deletions src/components/MessagesList/MessagesGroup/Message/MessagePart/FilePreview.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,22 @@
:class="{ 'file-preview--viewer-available': isViewerAvailable, 'file-preview--upload-editor': isUploadEditor }"
@click="handleClick"
@keydown.enter="handleClick">
<img v-if="(!isLoading && !failed)"
v-tooltip="previewTooltip"
:class="previewImageClass"
class="file-preview__image"
alt=""
:src="previewUrl">
<img v-if="!isLoading && failed"
:class="previewImageClass"
alt=""
:src="defaultIconUrl">
<div
v-if="!isLoading"
class="image-container"
:class="{'playable': isPlayable}">
<span v-if="isPlayable" class="play-video-button icon-play-white" />
<img v-if="!failed"
v-tooltip="previewTooltip"
:class="previewImageClass"
class="file-preview__image"
alt=""
:src="previewUrl">
<img v-else
:class="previewImageClass"
alt=""
:src="defaultIconUrl">
</div>
<span v-if="isLoading"
v-tooltip="previewTooltip"
class="preview loading" />
Expand Down Expand Up @@ -272,6 +278,15 @@ export default {

return false
},
isPlayable() {
// don't show play button for direct renders
if (this.failed || !this.isViewerAvailable || this.previewType !== PREVIEW_TYPE.PREVIEW) {
return false
}

// videos only display a preview, so always show a button if playable
return this.mimetype === 'image/gif' || this.mimetype.startsWith('video/')
},
internalAbsolutePath() {
if (this.path.startsWith('/')) {
return this.path
Expand Down Expand Up @@ -398,6 +413,42 @@ export default {
max-height: 64px;
}

.image-container {
display: inline-block;
position: relative;

&.playable {
.preview {
transition: filter 250ms ease-in-out;
}

.play-video-button {
position: absolute;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
padding: 22px;
border: 2px solid white;
border-radius: 25px;
opacity: 0.8;
z-index: 1;
transition: opacity 250ms ease-in-out;
background-size: 25px;
background-position-x: 11px;
}

&:hover {
.preview {
filter: brightness(80%);
}

.play-video-button {
opacity: 1;
}
}
}
}

.mimeicon {
min-height: 128px;
}
Expand Down