Test against oracle

[nickvergessen]

• Based on Create a new table for internal signaling and guest names with a PK #4735

[PVince81]

A nice start...

Nextcloud was successfully installed
An exception occurred while executing 'INSERT INTO "oc_talk_commands" ("app", "command", "name", "script", "response", "enabled") VALUES(?, ?, ?, ?, ?, ?)' with params ["", "help", "talk", "", 1, 3]:

ORA-01400: cannot insert NULL into ("AUTOTEST"."oc_talk_commands"."script")

[nickvergessen]

• Missing "update" step for the help command

[nickvergessen]

Rebased to add "listable" column on the select

[PVince81]

for readability on the calling side, I think I wouldn't make the alias optional.
I came here to check as I was confused where the alias comes from

[nickvergessen]

The alias is optional?

[nickvergessen]

Ah, you would n't.

Well it's r for room, a for attendee and s for session. Your IDE (if you have one) will also tell you that. Not a huge fan of adding hundreds of '(a|r|s) in the code just for lazy non-IDE users

[PVince81]

it's not only for non-IDE but also when reading the code on Github for example, like when reviewing code changes or viewing a commit / diff on Github or CLI

but as you like, not a big issue to infer the alias

[PVince81]

I have the same composer problem with the oci pipeline, not sure when this started happening: https://github.com/nextcloud/guests/pull/511/checks?check_run_id=1558214699

[nickvergessen]

We use dev-master of christophwurst nextcloud package and the was accidentally broken 🙃

[nickvergessen]

Okay actually the problem was we first installed composer deps and then set the php version, so it ran composer with 8.0 before switching to 7.4
Nevertheless this led to the relevant fix in the dependency so 8.0 will work in the future.

[PVince81]

👍