Skip to content

Create a new table for internal signaling and guest names with a PK #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 2 commits into from
Dec 11, 2020
Merged

Create a new table for internal signaling and guest names with a PK #4735

PVince81 merged 2 commits into from
Dec 11, 2020

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Dec 9, 2020

Signed-off-by: Joas Schilling [email protected]

@nickvergessen nickvergessen added this to the 💚 Next Major (21) milestone Dec 9, 2020
@nickvergessen nickvergessen force-pushed the techdebt/noid/cluster-compatibility branch from 01516f8 to fbf72c1 Compare December 9, 2020 16:03
@nickvergessen nickvergessen mentioned this pull request Dec 9, 2020
Merged
1 task
@PVince81
Copy link
Member

PVince81 commented Dec 10, 2020

@nickvergessen mind adding more context to the PR to explain what this is about and why we need it ? (our future selves will be thankful)

@PVince81
Copy link
Member

PVince81 commented Dec 10, 2020

aha, the branch name contains a clue "cluster-compatibility"

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 10, 2020 •
edited
Loading

Yeah, so tables need a primary key in order to work in Galera and other clusters:
https://mariadb.com/kb/en/mariadb-galera-cluster-known-limitations/

All tables should have a primary key (multi-column primary keys are supported). DELETE operations are unsupported on tables without a primary key. Also, rows in tables without a primary key may appear in a different order on different nodes.

Server was fixed in nextcloud/server@d5df033#diff-723d474847ce3f8926be66be2147d580e43f9a021655b56b6942d683ed408b49

PVince81
PVince81 approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks fine, see minor comment.

I did a quick test with some data in the table and the guest names were moved properly to the new table.

@PVince81
Copy link
Member

PVince81 commented Dec 10, 2020

there's a chat integration test that failed, maybe rebase to try again

@nickvergessen
Copy link
Member Author

nickvergessen commented Dec 10, 2020

It was actually a valid fail for inserting a guest name.

PVince81
PVince81 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice catch

@PVince81 PVince81 merged commit be0ed4a into master Dec 11, 2020
@PVince81 PVince81 deleted the techdebt/noid/cluster-compatibility branch December 11, 2020 07:37
@nickvergessen nickvergessen mentioned this pull request Dec 14, 2020
Merged
@PVince81 PVince81 mentioned this pull request Dec 16, 2020
Closed
@nickvergessen nickvergessen mentioned this pull request Dec 18, 2020
Merged
This was referenced Feb 19, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

No one assigned

Labels

4. to release technical debt

Projects

None yet

Milestone

v11.0.0-alpha.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @PVince81