Fix call button overlap in sidebar chat #4590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to recent changes to the scroll component, the call button in sidebar chat needs to be adjusted to float on top of the chat. Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
approved these changes
Nov 13, 2020
nickvergessen
deleted the
bugfix/noid/fix-sidebar-chat-button-overlap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes to the scroll component, the
call button in sidebar chat needs to be
adjusted to float on top of the chat.
Before:
After:
Note: the double scrollbar is unrelated. The bigger scrollbar is the one from the files app as I have enough files to make it scroll.
Fixes #4530 (comment)