Skip to content

Feature/noid/conversation settings error handling #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PVince81 wants to merge 2 commits into from
Closed

Feature/noid/conversation settings error handling #4671

PVince81 wants to merge 2 commits into from

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Nov 25, 2020 •
edited
Loading

Follow up of #4576 for:

  • error handling to reset checkboxes after an error

  • disable lock conversation field

  • REQUIRES: base PR

  • REQUIRES: participant mixin

@PVince81 PVince81 added this to the 💚 Next Major (21) milestone Nov 25, 2020
@PVince81 PVince81 self-assigned this Nov 25, 2020
@PVince81 PVince81 mentioned this pull request Nov 25, 2020
Merged
12 tasks
@PVince81 PVince81 force-pushed the feature/noid/conversation-settings-error-handling branch from d0d75bd to 04160e8 Compare November 26, 2020 15:23
@PVince81 PVince81 mentioned this pull request Jan 14, 2021
Merged
@PVince81 PVince81 force-pushed the feature/noid/conversation-settings-error-handling branch from 04160e8 to 0601187 Compare January 14, 2021 12:21
@PVince81
Copy link
Member Author

PVince81 commented Feb 19, 2021

  • some troubles because the conversation object is not getting updated despite the call... the dialog is tied to an older instance

@PVince81
Copy link
Member Author

PVince81 commented Feb 19, 2021

  • fix service calls to actually throw out the exception instead of skipping, otherwise we can't catch error cases to display the error

@nickvergessen
Copy link
Member

nickvergessen commented May 7, 2021

Status?

@PVince81
Copy link
Member Author

PVince81 commented May 18, 2021

not worth the effort => closed

@PVince81 PVince81 closed this May 18, 2021
@nickvergessen nickvergessen deleted the feature/noid/conversation-settings-error-handling branch July 27, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PVince81 PVince81

Labels

2. developing

Projects

None yet

Milestone

v12.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81 @nickvergessen