Introduce participant mixin #4672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove duplication of the "get current participant" logic all over the place and also for future use. Signed-off-by: Vincent Petry <[email protected]>
PVince81
commented
Nov 25, 2020
src/components/LeftSidebar/NewGroupConversation/NewGroupConversation.vue
Outdated
Show resolved
Hide resolved
2 tasks
PVince81
force-pushed
the
techdebt/noid/participant-mixin
branch
from
dc7c185 to
8728e14
Compare
This also fixes a discrepancy in the participant method where the token check was mistakenly inverted so that a dummy disconnected participant would be returned despite being in a call. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
techdebt/noid/participant-mixin
branch
from
8728e14 to
699df4b
Compare
Read the current conversation token directly from the store in both participant and isInCall mixins. Signed-off-by: Vincent Petry <[email protected]>
nickvergessen
approved these changes
Nov 26, 2020
Member
Author
|
I retested the checkboxes items in the OP and all went fine, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove duplication of the "get current participant" logic all over
the place and also for future use.
Open issue:
Tested based on the diff: