Fix not sending signaling messages to participants without a Peer object #4686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
modified the milestones:
11.0.0-alpha.1,
💚 Next Major (21),
11.0.0-alpha.2,
💚 Next Alpha (21)
Member
|
Master is 22 now |
danxuliu
force-pushed
the
fix-not-sending-signaling-messages-to-participants-without-a-peer-object
branch
from
fb7409b to
1e23cc4
Compare
PVince81
reviewed
May 31, 2021
PVince81
reviewed
May 31, 2021
4 tasks
"webrtc.sendToAll" only sends the signaling message to participants for which there is a Peer object. Due to this now it also emits an event that is handled by the WebRTC wrapper to send the message too to the rest of participants in the call that do not have a Peer object. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Participants can raise their hand even if there is no Peer object for them (that is, if they are not sending audio nor video). Therefore the received "raiseHand" signaling message needs to be handled in a general way outside of the Peer object. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
|
Member
|
Rebase was clean, I will push it so we see that tests pass |
nickvergessen
force-pushed
the
fix-not-sending-signaling-messages-to-participants-without-a-peer-object
branch
from
1e23cc4 to
5d51bd2
Compare
Member
At least android worked, iOS doesn't work with master atm.
done
SIP doesn't work with master atm. |
Member
|
I would say let's merge and then recheck with iOS and SIP once they are there. |
nickvergessen
approved these changes
Jun 7, 2021
Member
Author
👍 Thanks for the testing! |
nickvergessen
deleted the
fix-not-sending-signaling-messages-to-participants-without-a-peer-object
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webrtc.sendToAllonly sends the signaling message to participants for which there is a Peer object. Due to this now it also emits and event that is handled by the WebRTC wrapper to send the message too to the rest of participants in the call that do not have a Peer object.Sending signaling messages to participants without peers is currently needed for "raise hand" messages, and it will be needed for mute/unmute messages once the data channels are removed.
This pull request also fixes receiving raised hand events from participants without a Peer object, which could be useful in the webcast mode.
Besides the fix also some unneeded code was removed.Extracted to its own pull request.Pending:
roomTypein signaling messages to participants without peersHow to test (scenario 1)
Result with this pull request
User B sees that user A raised the hand
Result without this pull request
User B does not see that user A raised the hand
How to test (scenario 2)
Result with this pull request
User A sees that user B raised the hand
Result without this pull request
User A does not see that user B raised the hand
How to test (scenario 3)
Result with this pull request
User A sees that user B raised the hand
Result without this pull request
User A does not see that user B raised the hand