Remove unneeded webrtc code #5679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Neither "webrtcSupport.prefix === 'moz'", "pcConfig.iceTransports" or "candidate.candidate.candidate" were ever set, so the check always failed. Moreover, currently candidates are restricted based on the transport only to test the TURN server. This is done through the "iceTransportRelay" parameter and is handled by the browser itself, so there is no need to fix the code, it can be simply removed. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The WebUI no longer uses the "prefix" parameter, and it was never used by the mobile apps. The Android app declares the field in its NCSignalingMessage parcelable object, but if a received message does not contain the field it will be just set to an empty value. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
2. developing
feature: WebRTC 🚡
5 tasks
Member
|
Is this from dropping old FF versions? |
Member
Author
|
No, it is unrelated; the code was already dead when old Firefox versions were dropped. |
nickvergessen
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little cleanup of the legacy SimpleWebRTC code.