Follow up for SIP changes

[nickvergessen]

• Make sure the key calculation is always unique
  before it was s#0 for all email invites
• guests should no see the dial-in info panel
• Always generate PINs for logged in users when SIP is enabled (not only on join)
• Add capability and docs

Integration tests will be done in a new PR based on #4698

Fix #4677

[nickvergessen]

Rebased to solve the TopBar conflict

[PVince81]

• improve panel style, doesn't look that nice (could be done separately)

[PVince81]

See minor comments.

Will approve after I'm done testing.

[PVince81]

• idea: use telephone link (<a href="tel:123-456-7890">123-456-7890</a>) so that if someone opened Talk web on mobile, they can call right away. Could be part of the above.

actually, this is part of the dialin info, so would require markdown there or something formattable.
=> enhancement for later

[nickvergessen]

idea: use telephone link (123-456-7890) so that if someone opened Talk web on mobile, they can call right away. Could be part of the above.

actually, this is part of the dialin info, so would require markdown there or something formattable.
=> enhancement for later

Yeah Markup doesn't really work with the clients. Also you can have multiple numbers and the user needs to be aware which one to use instead of clicking the first one. Also if clicking, it should be phonnumber,00token,pin which would automatically verify the user already.

[PVince81]

Users that are already in the room need to rejoin as well to get a PIN

In my local test with internal signaling I didn't need to rejoin.
Had admin and bob in the channel, with settings panel open.
After enabling SIP as admin and waiting a bit, the dial-in info + pin appeared there for both users (no page refresh)

[nickvergessen]

Yeah that's why #4677 (comment) is ticked ;)

[PVince81]

👍 looks fine to me