Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 30, 2020

@nickvergessen nickvergessen force-pushed the tests/integration/for-sip branch from acf4d8f to bf720d5 Compare December 1, 2020 09:32
@nickvergessen nickvergessen force-pushed the tests/integration/for-sip branch from bf720d5 to deb0e31 Compare December 8, 2020 08:37
@nickvergessen nickvergessen marked this pull request as ready for review December 8, 2020 08:37
@nickvergessen nickvergessen force-pushed the tests/integration/for-sip branch 3 times, most recently from b1d1fd9 to 1a44a41 Compare December 8, 2020 08:43
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me 👍

@nickvergessen nickvergessen force-pushed the tests/integration/for-sip branch from 1a44a41 to 66584dd Compare December 8, 2020 09:35
@nickvergessen
Copy link
Member Author

Added a method to sort the results as the order seemed to be different on CI.

@nickvergessen nickvergessen merged commit b051c47 into master Dec 8, 2020
@nickvergessen nickvergessen deleted the tests/integration/for-sip branch December 8, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants