Skip to content

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 15, 2020

Removed cheat that used GuestManager directly from the guests app.
Now using occ guests:add to create guest account users.

@PVince81
Copy link
Member Author

I ran this locally and it worked

@PVince81 PVince81 force-pushed the techdebt/noid/guests-use-occ-no-cheating branch from 082433b to d9a0ae7 Compare December 17, 2020 14:07
Removed cheat that used GuestManager directly from the guests app.
Now using occ guests:add to create guest account users.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the techdebt/noid/guests-use-occ-no-cheating branch from d9a0ae7 to fffa965 Compare December 18, 2020 15:07
@PVince81
Copy link
Member Author

guests PR was merged.
rebased to retrigger CI, expecting green now

@PVince81 PVince81 marked this pull request as ready for review December 18, 2020 15:07
@nickvergessen nickvergessen merged commit e562a12 into master Dec 18, 2020
@nickvergessen nickvergessen deleted the techdebt/noid/guests-use-occ-no-cheating branch December 18, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants