Skip to content

Transpile more deps for IE 11 #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Jan 15, 2021
Merged

Transpile more deps for IE 11 #4829

nickvergessen merged 2 commits into from
Jan 15, 2021

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 22, 2020

In the listed order, every time I added a new exclude, a new one popped up. So I added them one by one.
Now in this PR we've reached a state where the Talk page loads in IE 11 but is missing some controls, likely due to the many JS errors happening in nextcloud-vue components (but no more syntax errors).

ie11-many-excludes

@PVince81 PVince81 added this to the 💚 Next Alpha (21) milestone Dec 22, 2020
@PVince81 PVince81 self-assigned this Dec 22, 2020
@PVince81 PVince81 mentioned this pull request Dec 22, 2020
Closed
@PVince81 PVince81 added the bug label Dec 22, 2020
@PVince81
Copy link
Member Author

PVince81 commented Dec 22, 2020

the last error seems to say that VPopover expects a string instead of a number, and we do pass in a number. We pass it indirectly to Popover which then copies it over to VPopover. Not sure why the property requirements would be different/buggy with IE 11...

@PVince81
Copy link
Member Author

PVince81 commented Dec 22, 2020

in components/Popover.vue of the lib it does accept a number:

    delay: {
      type: [String, Number, Object],
      default: () => getDefault('defaultDelay'),
    },

@nickvergessen
Copy link
Member

nickvergessen commented Jan 15, 2021

Conflicting files
package-lock.json

@nickvergessen
Copy link
Member

nickvergessen commented Jan 15, 2021

Allows chatting in IE11 again

@PVince81
Copy link
Member Author

PVince81 commented Jan 15, 2021

let me solve the conflict.

indeed the chat works for me, despite the million of errors in the console about data type validation in Vue properties...

@PVince81
Transpile more deps for IE 11
4af903f 
Added a bunch of extra deps to the transpilation list to make the app
work with IE 11.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81
Update @babel/preset-env and fix commonjs loading
5673db9 
Update @babel/preset-env to 7.12.11 has revealed an issue with the event
bus library related to the CommonJS format.

The webpack config was adjusted to properly load CommonJS libraries.

Signed-off-by: Vincent Petry <[email protected]>
@PVince81 PVince81 force-pushed the bugfix/4820/fix-ie11-modules branch from 58ac25f to 5673db9 Compare January 15, 2021 12:33
nickvergessen
nickvergessen approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes IE11 loading again

@nickvergessen
Copy link
Member

nickvergessen commented Jan 15, 2021

Merge?

@PVince81 PVince81 marked this pull request as ready for review January 15, 2021 12:48
@nickvergessen nickvergessen merged commit a853759 into master Jan 15, 2021
@nickvergessen nickvergessen deleted the bugfix/4820/fix-ie11-modules branch January 15, 2021 12:50
This was referenced Jan 15, 2021
Closed
Closed
@nickvergessen nickvergessen mentioned this pull request Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@PVince81 PVince81

Labels

4. to release bug

Projects

None yet

Milestone

v11.0.0-alpha.4

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81 @nickvergessen