Move matterbridge settings into the conversation settings dialog #4907
Conversation
marcoambrosini
force-pushed
the
bugfix/noid/move-conversation-settings-to-conversation-settings
branch
2 times, most recently
from
6c38773 to
108fff7
Compare
marcoambrosini
added
3. to review
enhancement
feature: frontend 🖌️
marcoambrosini
force-pushed
the
bugfix/noid/move-conversation-settings-to-conversation-settings
branch
from
108fff7 to
f8d1f66
Compare
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
Nice!
I don't know why the action button is not correctly sized.
Also, Matterbridge log is displayed in a modal on top of the settings modal. It's not shocking but what do you think about that?
Except that, looking good.
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
See comment from Julien
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
bugfix/noid/move-conversation-settings-to-conversation-settings
branch
from
f8d1f66 to
f3dcec5
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
|
Fixed the actions button hover feedback height and adjusted margins a bit
While I agree that it's not very elegant, I think that overall this is an improvement, especially the fact that we're moving every conversation related setting in one place as opposed to having them scattered around the UI. So I would say let's move forward with this :) |
|
Can the hovers have the same color? |
|
Okay it's a bug in the vue lib... |
|
Reported at nextcloud-libraries/nextcloud-vue#1665 |
nickvergessen
deleted the
bugfix/noid/move-conversation-settings-to-conversation-settings
branch
Signed-off-by: Marco Ambrosini [email protected]