Added quote border difference when own message is quoted #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a message different than an own is quoted, the border now appears grey. Otherwise for own messages it will still appear blue. Signed-off-by: Vincent Petry <[email protected]>
The parent-id property is required, so set it to avoid a warning in the console. Signed-off-by: Vincent Petry <[email protected]>
PVince81
added
3. to review
design
enhancement
feature: chat 💬
PVince81
requested review from
jancborchardt,
marcoambrosini and
nickvergessen
nickvergessen
requested changes
Jan 13, 2021
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Let's add guest support properly.
Currently any quote of a guest looks like it was "yours"
Properly detect reply to guest users to update the quote border accordingly. Signed-off-by: Vincent Petry <[email protected]>
Member
Author
|
@nickvergessen please check again, the guest quote should work now As mentioned above, refreshing the page as guest would change the guest id, so need to stay on the same page. |
nickvergessen
approved these changes
Jan 13, 2021
Member
|
Btw @PVince81 great detail quality-of-life improvement which really helps daily, thank you! :) |
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4174