Allow single video in stripe if screen share in progress #4941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the stripe was designed to not duplicate the video of whoever is displayed in the top. However, when a screen share is in progress, that user's video must move to the stripe so we can see them. Signed-off-by: Vincent Petry <[email protected]>
PVince81
force-pushed
the
bugfix/4817/allow-single-video-in-stripe
branch
from
cb213d1 to
041e2c5
Compare
Member
Author
|
nickvergessen
approved these changes
Jan 13, 2021
Member
|
Oh, now the todo pops up. Didn't show before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, the stripe was designed to not duplicate the video of whoever is
displayed in the top. However, when a screen share is in progress, that
user's video must move to the stripe so we can see them.
Fixes #4817
Left side is the user sharing the screen (admin). Own video is visible in the stripe and also the green video from the other user.
Right side is the user receiving the screen share (alice). The video of "admin" is visible also in the stripe.
So far so good, however when you expand the window width, it looks bad:
Thoughts @ma12-co ?