Correctly use the displayname for groups in admin settings #4943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
bug
feature: settings ⚙️
PVince81
approved these changes
Jan 14, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
👍 code looks fine, one minor comment
Tested and seen working for both the fields in the talk admin settings
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/4683/group-display-names-in-admin-settings
branch
from
7469071 to
54c94b7
Compare
PVince81
deleted the
bugfix/4683/group-display-names-in-admin-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4683
To create such a group use Nextcloud 18 or higher occ: