Fix display names with sip users #4956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…peers Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: SFU & SIP ☎️
feature: call 📹
Signed-off-by: Joas Schilling <[email protected]>
Member
|
@nickvergessen issue description and steps to reproduce, to understand the problem ? |
PVince81
reviewed
Jan 19, 2021
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Code looks fine in general as far as I could understand.
Please check my comment about the participant mixin to avoid further code duplication.
Member
Author
Currently SIP users have no display name for guests and logged in users, it just shows the user id/email addresss/guest id |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.