Skip to content

Remove "unsupported browser" warning for Opera #4974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Jan 21, 2021
Merged

Remove "unsupported browser" warning for Opera #4974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ If you have suggestions or problems, please [open an issue](https://github.com/n
|---|---|
| Firefox | ✔️ 52 or later |
| Chrome/Chromium | ✔️ 49 or later |
| Opera | ✔️ 72 or later |
| Edge | ⚠️ Latest versions <br> 🎤 Speakers are not promoted <br> 🏷 Name changes while a call is on-going are not reflected |
| Safari | ⚠️ 12 or later <br> ❌ No screensharing support <br> 🖥 Viewing screens of others' work |

Expand Down
7 changes: 6 additions & 1 deletion src/mixins/browserCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ const browserCheck = {
isChrome() {
return this.browser.name === 'Chrome' || this.browser.name === 'Chromium'
},
isOpera() {
return this.browser.name === 'Opera'
},
isSafari() {
return this.browser.name === 'Safari' || this.browser.name === 'Mobile Safari'
},
Expand All @@ -65,19 +68,21 @@ const browserCheck = {
isFullySupported() {
return (this.isFirefox && this.majorVersion >= 52)
|| (this.isChrome && this.majorVersion >= 49)
|| (this.isOpera && this.majorVersion >= 72)
|| (this.isSafari && this.majorVersion >= 12)
|| this.isEdge
},
// Disable the call button and show the tooltip
blockCalls() {
return (this.isFirefox && this.majorVersion < 52)
|| (this.isChrome && this.majorVersion < 49)
|| (this.isOpera && this.majorVersion < 72)
|| (this.isSafari && this.majorVersion < 12)
|| this.isIE
},
// Used both in the toast and in the call button tooltip
unsupportedWarning() {
return t('spreed', "The browser you're using is not fully supported by Nextcloud Talk. Please use the latest version of Mozilla Firefox, Microsoft Edge, Google Chrome or Apple Safari.")
return t('spreed', "The browser you're using is not fully supported by Nextcloud Talk. Please use the latest version of Mozilla Firefox, Microsoft Edge, Google Chrome, Opera or Apple Safari.")
},
// Used in CallButton.vue
callButtonTooltipText() {
Expand Down