Remove "unsupported browser" warning for Opera #4974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr0t4zy
force-pushed
the
pr/support-opera/1
branch
2 times, most recently
from
c5fb297 to
6aa32e9
Compare
Member
|
So the main issue/question is, if this is fully working with the webrtc-adapter lib we use: |
Contributor
Author
|
Opera will pass the check in linked utils.js. It will get "chrome" identification, there is an explicit comment:
Everything will work fine. |
pr0t4zy
force-pushed
the
pr/support-opera/1
branch
from
1f66e4f to
55b7362
Compare
Signed-off-by: Jacek <[email protected]>
pr0t4zy
force-pushed
the
pr/support-opera/1
branch
from
55b7362 to
1795852
Compare
nickvergessen
approved these changes
Jan 20, 2021
Contributor
Author
|
Thanks for approving! |
This was referenced Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Opera to the popup "The browser you're using is not fully supported by Nextcloud Talk. Please use the latest version of Mozilla Firefox, Microsoft Edge, Google Chrome or Apple Safari." and removes the popup (for Opera).
Note: Opera v36 is based on Chromium v49.