-
Notifications
You must be signed in to change notification settings - Fork 508
New button to disable lobby in sidebar #4997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vincent Petry <[email protected]>
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this button should be there. We could create a new action button in the moderation menu when the lobby is activated. That would make it for a 2 click operation, wouldn't it be enough? If not I would say we add a circular unlabeled button beside the moderation menu (only when the lobby is enabled)
|
@ma12-co we should also fulfil #4982 which requires a way to find out whether the lobby is enabled without extra clicks. The button being present would already be a sign. |
Only the disable is there and that must be. It must be really prominent and is mostly the next thing to be done in meetings. |
|
What about
|
unlabeled with what icon ? |
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and good enough for now
Maybe message lock? |
|
It needs to be super obvious. So if it's only an icon, it needs to be primary to make sure it's right into the eye. |
I'd have suggested yellow (warning).
If you happen to have that part of the app visible at that given moment. The main problem is that we're placing this button in an arbitrary place. |
Or the lobby button, so it's obvious that it's the lobby... |
|
but clicking a button that looks like a bell doesn't tell me what the button does intuitively, so would need a tooltip to make it clear it's about disabling it, not enabling |
|
Well so as you can see in the ticket people have the sidebar open and check the participant list in such cases. So it's not arbitrary really. |
Agree on that a bell doesn't work. And for sure a tooltip would be needed! |
I really don't like the design of it, but fine if you see it fit
wiswedel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great implementation. Does exactly what it promises (and the wording refers 1:1 to the "enable" mechanism 👍).
|
Let's move forward for now. We can iterate on the design later on when having another look bird's eye vue at the lobby feature. |
|
Icon in question is |
Fixes #4981
Fixes #4982
Note: I tried adding more information like the remaining time until meeting start, but it would take too much space and make the sidebar look too crowded. Also the moment library doesn't generate nice compact human readable texts for remaining durations. So if we do want this: needs further research.