Skip to content

Conversation

@PVince81
Copy link
Member

@PVince81 PVince81 commented Jan 22, 2021

image

Fixes #4981
Fixes #4982

Note: I tried adding more information like the remaining time until meeting start, but it would take too much space and make the sidebar look too crowded. Also the moment library doesn't generate nice compact human readable texts for remaining durations. So if we do want this: needs further research.

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this button should be there. We could create a new action button in the moderation menu when the lobby is activated. That would make it for a 2 click operation, wouldn't it be enough? If not I would say we add a circular unlabeled button beside the moderation menu (only when the lobby is enabled)

@PVince81
Copy link
Member Author

@ma12-co we should also fulfil #4982 which requires a way to find out whether the lobby is enabled without extra clicks. The button being present would already be a sign.

@nickvergessen
Copy link
Member

I don't think this button should be there.

Only the disable is there and that must be. It must be really prominent and is mostly the next thing to be done in meetings.

@marcoambrosini
Copy link
Member

What about

circular unlabeled button beside the moderation menu (only when the lobby is enabled)

@PVince81
Copy link
Member Author

What about

circular unlabeled button beside the moderation menu (only when the lobby is enabled)

unlabeled with what icon ?

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and good enough for now

@marcoambrosini
Copy link
Member

unlabeled with what icon ?

Maybe message lock?

@nickvergessen
Copy link
Member

It needs to be super obvious. So if it's only an icon, it needs to be primary to make sure it's right into the eye.
But I think a labeled button is much better and more obvious.

@marcoambrosini
Copy link
Member

marcoambrosini commented Jan 22, 2021

it needs to be primary

I'd have suggested yellow (warning).

But I think a labeled button is much better and more obvious.

If you happen to have that part of the app visible at that given moment.

The main problem is that we're placing this button in an arbitrary place.

@nickvergessen
Copy link
Member

unlabeled with what icon ?

Maybe message lock?

Or the lobby button, so it's obvious that it's the lobby...
https://github.com/nextcloud/spreed/blob/master/img/lobby.svg

@PVince81
Copy link
Member Author

but clicking a button that looks like a bell doesn't tell me what the button does intuitively, so would need a tooltip to make it clear it's about disabling it, not enabling

@nickvergessen
Copy link
Member

Well so as you can see in the ticket people have the sidebar open and check the participant list in such cases. So it's not arbitrary really.

@marcoambrosini
Copy link
Member

marcoambrosini commented Jan 22, 2021

but clicking a button that looks like a bell doesn't tell me what the button does intuitively, so would need a tooltip to make it clear it's about disabling it, not enabling

Agree on that a bell doesn't work. And for sure a tooltip would be needed!

@marcoambrosini marcoambrosini dismissed their stale review January 22, 2021 13:55

I really don't like the design of it, but fine if you see it fit

Copy link
Contributor

@wiswedel wiswedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation. Does exactly what it promises (and the wording refers 1:1 to the "enable" mechanism 👍).

@PVince81
Copy link
Member Author

Let's move forward for now. We can iterate on the design later on when having another look bird's eye vue at the lobby feature.

@PVince81 PVince81 merged commit 2d5af3a into master Jan 22, 2021
@PVince81 PVince81 deleted the enh/4981/disable-lobby-from-sidebar branch January 22, 2021 14:00
@nickvergessen
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review feature: chat 💬 Chat and system messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make lobby being active more visible to moderators Make lobby disabling more accessible

5 participants