Improve deck card UI #5074
Merged
Improve deck card UI #5074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
marcoambrosini
commented
Feb 3, 2021
marcoambrosini
commented
marcoambrosini
added
3. to review
enhancement
feature: frontend 🖌️
marcoambrosini
force-pushed
the
improve-deck-card-ui
branch
from
f82f787 to
ec77c95
Compare
nickvergessen
force-pushed
the
improve-deck-card-ui
branch
from
ec77c95 to
634e6c2
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/DeckCard.vue
Show resolved
Hide resolved
nickvergessen
force-pushed
the
improve-deck-card-ui
branch
from
634e6c2 to
1f4f689
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
improve-deck-card-ui
branch
from
1f4f689 to
a7bc25a
Compare
Member
Author
|
ready to review again! |
| target="_blank"> | ||
| <strong>{{ name }}</strong> | ||
| <div class="deck-card__lineone"> | ||
| <div class="icon-deck" /> |
Member
There was a problem hiding this comment.
icon is undefined when deck is disabled. Maybe we can copy and redefine it for that case?
Member
There was a problem hiding this comment.
Also the icon is black on dark mode 🤷
Member
Author
There was a problem hiding this comment.
icon is undefined when deck is disabled. Maybe we can copy and redefine it for that case?
Silly question maybe, but if deck is unavailable what's the point of all this? Shouldn't we display a warning instead of the card?
Member
There was a problem hiding this comment.
Dark mode seems healed now 🤔
nickvergessen
approved these changes
Feb 10, 2021
Member
|
/backport to stable21.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.