Skip to content

Improve deck card UI #5074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Feb 10, 2021
Merged

Improve deck card UI #5074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 65 additions & 3 deletions src/components/MessagesList/MessagesGroup/Message/MessagePart/DeckCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,21 @@

<template>
<a
v-tooltip.bottom="deckLocation"
class="external"
class="deck-card"
:href="link"
:aria-label="deckCardAriaLabel"
target="_blank">
<strong>{{ name }}</strong>
<div class="deck-card__lineone">
<div class="icon-deck" />
Copy link
Member

@nickvergessen nickvergessen Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon is undefined when deck is disabled. Maybe we can copy and redefine it for that case?

Copy link
Member

@nickvergessen nickvergessen Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the icon is black on dark mode 🤷

Copy link
Member Author

@marcoambrosini marcoambrosini Feb 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon is undefined when deck is disabled. Maybe we can copy and redefine it for that case?

Silly question maybe, but if deck is unavailable what's the point of all this? Shouldn't we display a warning instead of the card?

Copy link
Member

@nickvergessen nickvergessen Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well ignore that part

Copy link
Member

@nickvergessen nickvergessen Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark mode seems healed now 🤔

<div class="title">
{{ name }}
</div>
</div>
<div class="deck-card__linetwo">
<div>
{{ deckLocation }}
</div>
</div>
</a>
</template>

Expand Down Expand Up @@ -73,6 +83,58 @@ export default {
board: this.boardname,
})
},
deckCardAriaLabel() {
return t('spreed', 'Deck Card')
},
},
}
</script>

<style lang="scss" scoped>
.deck-card {
display: flex;
transition: box-shadow 0.1s ease-in-out;
box-shadow: 0 0 2px 0 var(--color-box-shadow);
border-radius: var(--border-radius-large);
font-size: 100%;
background-color: var(--color-main-background);
margin: 12px 0;
max-width: 300px;
padding: 8px 16px;
flex-direction: column;
white-space: nowrap;
&:hover,
&:focus{
box-shadow: 0 0 5px 0 var(--color-box-shadow);
}
&__lineone {
height: 30px;
display: flex;
justify-content: flex-start;
align-items: center;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;

.title {
margin-left: 8px;
}
}
&__linetwo {
height: 30px;
color: var(--color-text-lighter);
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
// Dark theme
body.dark &, body.theme--dark & {
border: 2px solid var(--color-border);
}
}

.icon-deck {
opacity: .8;
}

</style>