Skip to content

Play sounds on call actions #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Mar 26, 2021
Merged

Play sounds on call actions #5410

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
09341af
Play sounds when someone is joining or leaving a call
nickvergessen Mar 24, 2020
32d3cde
Play waiting sound when you are alone in a call
nickvergessen Mar 27, 2020
0e9b41b
Adjust sound handling as discussed with Jan
nickvergessen Mar 27, 2020
82d0d83
Save setting for play sounds
nickvergessen Jul 3, 2020
b327b96
Fix initial state handling
nickvergessen Feb 10, 2021
cc8bc68
Only play the waiting sound 3 times
nickvergessen Dec 18, 2020
89cc62c
Only play leave sound when a call participant leaves
nickvergessen Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Only play leave sound when a call participant leaves 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Mar 26, 2021
commit 89cc62ce1015fb9a8bc104df4bb85314aec033d1
2 changes: 2 additions & 0 deletions src/utils/webrtc/models/CallParticipantCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ CallParticipantCollection.prototype = {
this._trigger('remove', [callParticipantModel])

callParticipantModel.destroy()
return true
}
return false
},

}
9 changes: 6 additions & 3 deletions src/utils/webrtc/webrtc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,13 +343,16 @@ function usersChanged(signaling, newUsers, disconnectedSessionIds) {
disconnectedSessionIds.forEach(function(sessionId) {
console.debug('Remove disconnected peer', sessionId)
webrtc.removePeers(sessionId)
callParticipantCollection.remove(sessionId)

if (callParticipantCollection.remove(sessionId)) {
playLeaveSound = true
}

if (delayedConnectionToPeer[sessionId]) {
clearInterval(delayedConnectionToPeer[sessionId])
delete delayedConnectionToPeer[sessionId]
playLeaveSound = true
}

playLeaveSound = true
})

previousUsersInRoom = arrayDiff(previousUsersInRoom, disconnectedSessionIds)
Expand Down