-
Notifications
You must be signed in to change notification settings - Fork 508
Play sounds on call actions #5410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Play sounds on call actions #5410
Conversation
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
within the last 5 seconds
Isn't it too much?
We should probably leave it till there's a more reliable way to do this? |
The sound file is already ~3 sec long, so if it starts again after 5 seconds, there were 2 seconds of break. If you think about bigger calls this already sounds problematic enough. But that is why @jancborchardt and me picked 5 seconds in the end |
This comment has been minimized.
This comment has been minimized.
53836a2 to
aca9cf8
Compare
|
Ready for final testing from my side |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
aca9cf8 to
cc8bc68
Compare
marcoambrosini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In as is as discussed but I'd like to leave two comments here:
- IMO sounds are too long and we should cut them, they should be snap like long, not several seconds long;
- I find the sound when starting the call a bit annoying, I'd remove it altogether;
|
|
Fixed the problem with leaving as a chat-user only |
Signed-off-by: Joas Schilling <[email protected]>
fb7a28c to
89cc62c
Compare
Fix #2345
Fix #1072
(as discussed with @jancborchardt ):