Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 24, 2021

Fix #2345
Fix #1072

(as discussed with @jancborchardt ):

  • Play a sound when someone joins a call (only if not played within the last 5 seconds)
  • Play a sound when someone leaves a call (only if not played within the last 5 seconds)
  • Play a waiting sound when you are alone in a call (only 3 times)
  • Have a setting to opt out of noises completely
  • Check if we can play a sound when a call comes in, or are browsers too annoying in blocking it? (ref Add basic sound notification #5335 (comment) + Sound on talk notifications notifications#116 (comment) )
  • Add a note that sounds can't play on safari atm
  • Check CSP changes

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

within the last 5 seconds

Isn't it too much?

@marcoambrosini
Copy link
Member

Check if we can play a sound when a call comes in, or are browsers too annoying in blocking it?

We should probably leave it till there's a more reliable way to do this?
I mean, If you know as a user that the you should expect a sound, you might start to rely on it as a notification, but if things are so precarious there we might just create confusion by doing this

@nickvergessen
Copy link
Member Author

within the last 5 seconds

Isn't it too much?

The sound file is already ~3 sec long, so if it starts again after 5 seconds, there were 2 seconds of break. If you think about bigger calls this already sounds problematic enough. But that is why @jancborchardt and me picked 5 seconds in the end

@nickvergessen

This comment has been minimized.

@nickvergessen nickvergessen force-pushed the feature/1072/play-sounds-on-call-actions branch from 53836a2 to aca9cf8 Compare March 25, 2021 09:04
@nickvergessen
Copy link
Member Author

Ready for final testing from my side

@nickvergessen nickvergessen force-pushed the feature/1072/play-sounds-on-call-actions branch from aca9cf8 to cc8bc68 Compare March 26, 2021 08:25
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In as is as discussed but I'd like to leave two comments here:

  • IMO sounds are too long and we should cut them, they should be snap like long, not several seconds long;
  • I find the sound when starting the call a bit annoying, I'd remove it altogether;

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 26, 2021

  • Sound also plays when a participant not in the call leaves the room

@nickvergessen
Copy link
Member Author

Fixed the problem with leaving as a chat-user only

@nickvergessen nickvergessen force-pushed the feature/1072/play-sounds-on-call-actions branch from fb7a28c to 89cc62c Compare March 26, 2021 11:01
@nickvergessen nickvergessen merged commit 2ed0de4 into master Mar 26, 2021
@nickvergessen nickvergessen deleted the feature/1072/play-sounds-on-call-actions branch March 26, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

acoustic feedback when a user joins/leaves a call Add acoustic feedback for a call actions

3 participants