Skip to content

Add meaningful conversation info to topbar. #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoambrosini merged 7 commits into from
May 21, 2021
Merged

Add meaningful conversation info to topbar. #5596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9c3e468
Add conversation avatar, name and description to topbar
marcoambrosini May 6, 2021
944cf4f
Open conversation settings upon clicking on header
marcoambrosini May 10, 2021
7daf60f
Fix MainView Layout
marcoambrosini May 11, 2021
e41f5dd
Fix callview
marcoambrosini May 12, 2021
b3322ac
Fix typo
marcoambrosini May 12, 2021
52cd0d9
Add description tooltip
marcoambrosini May 12, 2021
e3e1b0a
Render links in description tooltip
marcoambrosini May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,10 @@ export default {
.content {
height: 100%;

//FIXME: remove this v-deep once nextcloud vue v4 is adopted
::v-deep .app-navigation-toggle {
top: 10px;
right: -10px;
top: 8px;
right: -8px;
border-radius: var(--border-radius-pill);
}

Expand Down
2 changes: 1 addition & 1 deletion src/assets/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ $message-utils-width: 100px;
//message form max height
$message-form-max-height: 180px;

$top-bar-height: 60px;
$top-bar-height: 61px;

$color-call-background: #444444;
$color-guests-avatar: #ffffff;
Expand Down
3 changes: 1 addition & 2 deletions src/components/ChatView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,10 @@ export default {
<style lang="scss" scoped>
.chatView {
width: 100%;
height: 100%;
display: flex;
flex-direction: column;
flex-grow: 1;
position: absolute;
min-height: 0;
}

.dragover {
Expand Down
2 changes: 0 additions & 2 deletions src/components/NewMessageForm/NewMessageForm.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,6 @@ export default {
@import '../../assets/buttons';

.wrapper {
position: sticky;
Copy link
Member

@PVince81 PVince81 May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional extra change ?

Copy link
Member Author

@marcoambrosini marcoambrosini May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

bottom: 0;
display: flex;
justify-content: center;
padding: 12px 0;
Expand Down
1 change: 1 addition & 0 deletions src/components/RightSidebar/RightSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ export default {
.app-sidebar-tabs__content #tab-chat {
/* Remove padding to maximize the space for the chat view. */
padding: 0;
height: 100%;
}

</style>
Loading