Skip to content

Add meaningful conversation info to topbar. #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marcoambrosini merged 7 commits into from
May 21, 2021
Merged

Add meaningful conversation info to topbar. #5596

marcoambrosini merged 7 commits into from
May 21, 2021

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented May 10, 2021 •
edited
Loading

  • Display conversation avatar, name and description;
  • Open conversation settings on click;
  • Default with sidebar closed now that the conversation info is displayed (cc @nickvergessen);
Peek.2021-05-10.16-01.mp4

@marcoambrosini marcoambrosini added this to the 💖 Next Major (22) milestone May 10, 2021
@marcoambrosini marcoambrosini self-assigned this May 10, 2021
@marcoambrosini marcoambrosini force-pushed the feature/noid/topbar branch 2 times, most recently from 596d27d to 4ec3e5b Compare May 10, 2021 15:34
nickvergessen
nickvergessen previously requested changes May 10, 2021
View reviewed changes
@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 11, 2021

sidebar shown by default again

nickvergessen
nickvergessen reviewed May 11, 2021
View reviewed changes
jancborchardt
jancborchardt approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! :) Except the license typo @nickvergessen noted

@nickvergessen
Copy link
Member

nickvergessen commented May 11, 2021

  • There is no tooltip/hover-popover etc to see the full description when it is cut off. Not sure if that is confusing?
  • Links in the description are not clickable in the topbar but work in the sidebar

@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 11, 2021

There is no tooltip/hover-popover etc to see the full description when it is cut off. Not sure if that is confusing?

I made a pr to show it in the conversation settings/details on click #5605

@PVince81
Copy link
Member

PVince81 commented May 12, 2021

There is no tooltip/hover-popover etc to see the full description when it is cut off. Not sure if that is confusing?

I made a pr to show it in the conversation settings/details on click #5605

A tooltip / hover is still desirable. Opening such heavy dialog just to read the full description feels wrong.
For editing it's fine, yes. Not everyone can edit the description though.

@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 12, 2021

Opening such heavy dialog just to read the full description feels wrong.

I thought it would be fine giving that for everyone but moderators that dialog will be rather small.
Not too fond on the tooltip idea, It can be a potentially huge slab of text popping up as you move the mouse around.. Maybe a delayed one could work?

@PVince81
Copy link
Member

PVince81 commented May 12, 2021

Opening such heavy dialog just to read the full description feels wrong.

I thought it would be fine giving that for everyone but moderators that dialog will be rather small.
Not too fond on the tooltip idea, It can be a potentially huge slab of text popping up as you move the mouse around.. Maybe a delayed one could work?

Delayed makes sense, yes. As a user I wouldn't think of clicking on it to read it in full (unless on mobile where long press is the norm for tooltips).

@marcoambrosini marcoambrosini force-pushed the feature/noid/topbar branch 3 times, most recently from c30d3fa to 3101c49 Compare May 12, 2021 16:42
@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 12, 2021 •
edited
Loading

Added delayed tooltip. Not sure about the link thing, as the whole element is already a clickable <a> that brings up the conversation settings/info dialog. Maybe the link could be parsed and clickable within the tooltip itself

@marcoambrosini
Copy link
Member Author

marcoambrosini commented May 13, 2021

Having a bit of trouble with keeping the tooltip shown while hovering it. I wasn't able to find a solution yet.

PVince81
PVince81 reviewed May 21, 2021
View reviewed changes
@marcoambrosini
Add conversation avatar, name and description to topbar
9c3e468 
Signed-off-by: Marco Ambrosini <[email protected]>

Add conversation name and dedscription to topbar

Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Open conversation settings upon clicking on header
944cf4f 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix MainView Layout
7daf60f 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix callview
e41f5dd 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Fix typo
b3322ac 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Add description tooltip
52cd0d9 
Signed-off-by: Marco Ambrosini <[email protected]>
@marcoambrosini
Render links in description tooltip
e3e1b0a 
Signed-off-by: Marco Ambrosini <[email protected]>
PVince81
PVince81 reviewed May 21, 2021
View reviewed changes
src/components/NewMessageForm/NewMessageForm.vue
@import '../../assets/buttons';
.wrapper {
position: sticky;
Copy link
Member

@PVince81 PVince81 May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional extra change ?

Copy link
Member Author

@marcoambrosini marcoambrosini May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

PVince81
PVince81 approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 as discussed

see comment in case that change was not intentional

@marcoambrosini marcoambrosini merged commit bc9ea3b into master May 21, 2021
@marcoambrosini marcoambrosini deleted the feature/noid/topbar branch May 21, 2021 07:34
@marcoambrosini marcoambrosini mentioned this pull request May 21, 2021
Merged
@nickvergessen nickvergessen mentioned this pull request Jul 1, 2021
Merged
@nickvergessen nickvergessen mentioned this pull request Sep 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@marcoambrosini marcoambrosini

Labels

2. developing enhancement feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v12.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

5 participants

@marcoambrosini @nickvergessen @PVince81 @jancborchardt