Move description editor to conversation settings dialog #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jancborchardt
approved these changes
May 11, 2021
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks good!
Btw what’s a bit confusing is that the settings dialog doesn’t have the conversation title as orientation, would be nice to have, but separate issue. :)
PVince81
approved these changes
May 12, 2021
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
src/components/ConversationSettings/ConversationSettingsDialog.vue
Outdated
Show resolved
Hide resolved
Member
Author
It's all coming @jancborchardt :) |
marcoambrosini
force-pushed
the
feature/noid/improve-conversation-settings-dialog
branch
from
e60f8fc to
110d6ee
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
feature/noid/improve-conversation-settings-dialog
branch
from
110d6ee to
24e5aad
Compare
marcoambrosini
deleted the
feature/noid/improve-conversation-settings-dialog
branch
This was referenced May 18, 2021
Member
|
follow up to clean up leftovers: #5632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peek.2021-05-11.15-19.mp4
Signed-off-by: Marco Ambrosini [email protected]