Skip to content

[stable21] Fix connection quality warning shown due to stalled stats #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Jul 2, 2021
Merged

[stable21] Fix connection quality warning shown due to stalled stats #5924

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
587a116
Add helper method to get a string representation of an AverageStatValue
danxuliu Jun 24, 2021
185f919
Add logs for connection quality warnings
danxuliu Jun 24, 2021
f8f40a6
Fix stats being reset when enabling the analysis twice
danxuliu Jun 24, 2021
5bb110b
Convert "_connectionQuality" attribute to an array
danxuliu Jun 25, 2021
1352f12
Get attributes based on kind instead of explictly pass them
danxuliu Jun 25, 2021
74bb926
Extract adding the processed stats to its own method
danxuliu Jun 25, 2021
416bae0
Fix very bad quality reported due to stalled stats
danxuliu Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix stats being reset when enabling the analysis twice 
The stats were reset whenever "setAnalysisEnabledXXX(true)" was called.
Due to this, if the analysis for audio or video was already enabled and
the method was called again the stats were wrongly reset. The stats
should be reset only when the analysis is really started again.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Jul 2, 2021
commit f8f40a615fa4a3bdd0386bab6f2d94529e75852f
8 changes: 8 additions & 0 deletions src/utils/webrtc/analyzers/PeerConnectionAnalyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ PeerConnectionAnalyzer.prototype = {
},

setAnalysisEnabledAudio: function(analysisEnabledAudio) {
if (this._analysisEnabled['audio'] === analysisEnabledAudio) {
return
}

this._analysisEnabled['audio'] = analysisEnabledAudio

if (!analysisEnabledAudio) {
Expand All @@ -213,6 +217,10 @@ PeerConnectionAnalyzer.prototype = {
},

setAnalysisEnabledVideo: function(analysisEnabledVideo) {
if (this._analysisEnabled['video'] === analysisEnabledVideo) {
return
}

this._analysisEnabled['video'] = analysisEnabledVideo

if (!analysisEnabledVideo) {
Expand Down