Skip to content

[stable21] Fix connection quality warning shown due to stalled stats #5924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 7 commits into from
Jul 2, 2021
Merged

[stable21] Fix connection quality warning shown due to stalled stats #5924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
587a116
Add helper method to get a string representation of an AverageStatValue
danxuliu Jun 24, 2021
185f919
Add logs for connection quality warnings
danxuliu Jun 24, 2021
f8f40a6
Fix stats being reset when enabling the analysis twice
danxuliu Jun 24, 2021
5bb110b
Convert "_connectionQuality" attribute to an array
danxuliu Jun 25, 2021
1352f12
Get attributes based on kind instead of explictly pass them
danxuliu Jun 25, 2021
74bb926
Extract adding the processed stats to its own method
danxuliu Jun 25, 2021
416bae0
Fix very bad quality reported due to stalled stats
danxuliu Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/utils/webrtc/analyzers/AverageStatValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ const STAT_VALUE_TYPE = {
* the raw value that was added or the relative one after the conversion (which,
* for non cumulative values, will be the raw value too).
*
* A string representation of the current relative values can be got by calling
* "toString()".
*
* @param {int} count the number of instances to take into account.
* @param {STAT_VALUE_TYPE} type whether the value is cumulative or relative.
* @param {int} lastValueWeight the value to calculate the weights of all the
Expand Down Expand Up @@ -127,6 +130,22 @@ AverageStatValue.prototype = {
return weightedValues / weightsSum
},

toString() {
if (!this._relativeValues.length) {
return '[]'
}

let relativeValuesAsString = '[' + this._relativeValues[0]

for (let i = 1; i < this._relativeValues.length; i++) {
relativeValuesAsString += ', ' + this._relativeValues[i]
}

relativeValuesAsString += ']'

return relativeValuesAsString
},

}

export {
Expand Down
Loading