-
Notifications
You must be signed in to change notification settings - Fork 508
Inject room and attendee into chat notifier #6959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject room and attendee into chat notifier #6959
Conversation
danxuliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import of RoomNotFoundException should be removed in first commit and unit tests need to be fixed in second commit.
Other than the comments, code looks good (but I have not tested it).
vitormattos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally, working fine and get the same reducing of queries.
|
@danxuliu you fine with this step now? |
|
Just asking because it would be nice to get this in and then continue with #6340 |
58ff818 to
4397e63
Compare
danxuliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I split Vitor's commit in two fixups and added another fixup with the missing changes to the psalm docs.
In the end I did not replace if ($alreadyNotified === $userToNotify) { with if ($alreadyNotified['id'] === $userToNotify['id'] && $alreadyNotified['type'] === $userToNotify['type']) {. As explained, right now it should work fine, so let's adjust it in the future if the order in which the methods are called changes rather than preemptively adjust it now.
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
4397e63 to
c92c703
Compare
Steps
@allQuery count
chat@employee2@allCompare query log:
