Fix too short DataSet for shuffled samples when there is no unique IP address #1024
Conversation
DerDreschner
force-pushed
the
fix/860-error-on-merge-when-no-shuffle-possible
branch
from
320fc50 to
8acd395
Compare
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Makes sense! Thanks a lot!
| $max = count($positives); | ||
| $uniqueIps = $this->getUniqueIPsPerUser($positives); | ||
|
|
||
| if(empty($uniqueIps)) { |
There was a problem hiding this comment.
| if(empty($uniqueIps)) { | |
| if ($uniqueIps === []) { |
cs
|
/backport to stable31 |
|
/backport to stable30 |
|
Please squash your commits into one |
DerDreschner
force-pushed
the
fix/860-error-on-merge-when-no-shuffle-possible
branch
from
e85aa90 to
fbd29be
Compare
Done! :) |
Head branch was pushed to by a user without write access
…exception on merge Signed-off-by: David Dreschner <[email protected]>
DerDreschner
force-pushed
the
fix/860-error-on-merge-when-no-shuffle-possible
branch
from
9ccf606 to
49bbdbf
Compare
|
@ChristophWurst : I've run Unfortunately, the static code analysis fails as well due to deprecation warnings in the Could you please run the workflows again and mitigate the issue with the failed static code analysis run? Thanks!! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@ChristophWurst : Sorry to bother you again, but I hit the "re-request review" button and now it doesn't merge automatically, although all workflows are green now. Could you do it one more time? Thank you! 🙈 |
Apparently auto merge stops for forks once you push another time
|
|
/backport to stable32 |
2 participants
Generating shuffled samples is based on IP addresses which are used exclusively by one user. If no user has such an unique IP address, the returned DataSet object contains no IP address at all. This results in an exception during merge with the "regular" DataSet objects due to the different length.
To mitigate this, I now return an empty
Labeled()object which can be used in themergefunction of RubixML without any issues. Additionally, I revert the change from #810 asgenerateFromRealDatashouldn't be called without any unique IPs at all. I suspect that all people in #745 are affected by this bug in the first place and experience the error from #860 now.This should fix the latest reports in #860.