Skip to content

Conversation

@DerDreschner
Copy link
Collaborator

@DerDreschner DerDreschner commented Aug 22, 2025

As discussed in #1017, php-stemmer is a dependency of RubixML. They currently point to the version 3.0 of php-stemmer, which isn't fully compatible with PHP 8.4 due to a dependency on portable-utf8, which isn't that well maintained anyway. This issue is already handled by the maintainers of php-stemmer by releasing the version 4.0, which replaced portable-utf8 with joomla/string. This isn't a breaking change, so, the version bump was done just in case.

Until RubixML uses the latest version (see RubixML/ML#359), we can deploy a workaround and use php-stemmer 4.0 by using it as alias for version 3.0.

This fixes #1017.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you very much

@ChristophWurst ChristophWurst added bug Something isn't working 3. to review labels Sep 4, 2025
@ChristophWurst
Copy link
Member

@AndyXheli could you please give this a test? Thanks

@DerDreschner DerDreschner force-pushed the fix/1017-update-rubixml-dependency branch from 4d708fe to 7b4f1e4 Compare September 4, 2025 05:06
@DerDreschner
Copy link
Collaborator Author

@ChristophWurst : I've run php-cs here as well and squashed everything again. Could you please approve it again? Thanks!

@DerDreschner
Copy link
Collaborator Author

@ChristophWurst : php-cs-fixer needs to be updated as the version in vendor-bin isn't compatible with PHP 8.4, yet the nextcloud-version-matrix now wants to run against it.

@DerDreschner
Copy link
Collaborator Author

Created a bug report in nextcloud/coding-standard, as this is the package that the outdated version comes from (although we don't use the current version from them - but that doesn't matter as they didn't changed it in the latest version at all).

@DerDreschner
Copy link
Collaborator Author

#1028 should fix the issue as recommended by this comment.

@DerDreschner DerDreschner force-pushed the fix/1017-update-rubixml-dependency branch from 7b4f1e4 to 993b42f Compare September 4, 2025 09:38
@github-actions
Copy link

github-actions bot commented Sep 6, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@ChristophWurst ChristophWurst merged commit 16ba070 into nextcloud:master Sep 26, 2025
31 checks passed
@ChristophWurst
Copy link
Member

/backport to stable32

@ChristophWurst
Copy link
Member

Apologies for the late approval/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Nextcloud 31.0.7 PHP 8.4.10 Implicitly nullable parameter

2 participants