Skip to content

Conversation

@DerDreschner
Copy link
Collaborator

@DerDreschner DerDreschner commented Sep 4, 2025

In the latest pull requests, the pipeline for linting the PHP code fails as it wants to run against PHP 8.4 (see nextcloud/coding-standard#47).

One of the comments there recommend to update the workflow template, which this pull request does. I guess the main change is the use of steps.versions.outputs.php-min instead of steps.versions.outputs.php-available. This means it should always run with the lowest supported PHP version.

The other workflows differ from the template repository as well (e.g. different database versions on phpunit workflows), but I didn't want to change too much here.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ChristophWurst ChristophWurst merged commit 62cb991 into nextcloud:master Sep 4, 2025
31 checks passed
@github-actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants