-
Notifications
You must be signed in to change notification settings - Fork 30
[stable32] Update php-stemmer to 4.0 as workaround for full PHP 8.4 compatibility #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@AndyXheli please give this a test |
|
You got it! Give me a bit and I'll give it a try! Thanks @ChristophWurst |
|
Hey so i applied the patch im still seeing voku\helper\UTF8::reduce_string_array(): Implicitly marking parameter $remove_short_values as nullable is deprecated, the explicit nullable type must be used instead at /var/www/nextcloud/apps/suspicious_login/vendor/voku/portable-utf8/src/voku/helper/UTF8.php#13827 |
|
Did you also run |
|
Nope I did it wrong 😒 |
|
No worries. Can you try with installation of the replaced dependency? |
|
Okay testing looks good |
…ibility Signed-off-by: David Dreschner <[email protected]>
163c232 to
b79a8f7
Compare
ChristophWurst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as outdated.
This comment was marked as outdated.
I can confirm updating to the latest Nextcloud version 32.0.1 solved the problem. HINT: I advise to use another URL (eg. github.com) to download the zip file, otherwise the update might take 2 hours: |
Backport of PR #1027
Close #1035