Skip to content

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Apr 18, 2023

Resolves #2860

🖼️ Screenshots

Suggestion items Mention chip in edit field Mention chip in outgoing message
Screenshot_20230418_120821 Screenshot_20230418_125914 Screenshot_20230418_153650

🚧 TODO

Some details:

  • Similar to guests group mentions work with double quotes and specifying the type: @"group/admin"
  • Suggestions for groups should be shown when autocompleting
    • They are returned on the mentions endpoint, identify by source=groups and should be shown with label and group icon in the dropdown list
  • Group mentions should be rendered in the chat afterwards
    • They are like normal user and @all mentions just rich object parameters, this time with type user-group. We display them like all other mentions as a chip with a group icon as "avatar" (2 persons)

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Apr 18, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/2860/groupMentions branch 3 times, most recently from 2e39c62 to 2933342 Compare April 18, 2023 11:28
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews enhancement New feature or request feature: chat 🗨️ and removed 2. developing Work in progress labels Apr 18, 2023
@AndyScherzinger AndyScherzinger requested a review from mahibi April 18, 2023 13:39
@AndyScherzinger AndyScherzinger force-pushed the feature/2860/groupMentions branch from 2933342 to c82d60f Compare April 18, 2023 13:40
@AndyScherzinger AndyScherzinger added this to the 17.0.0 milestone Apr 18, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/2860/groupMentions branch from c82d60f to 513ec47 Compare April 18, 2023 13:44
@AndyScherzinger AndyScherzinger marked this pull request as ready for review April 18, 2023 13:44
@AndyScherzinger AndyScherzinger force-pushed the feature/2860/groupMentions branch from 513ec47 to b418e17 Compare April 18, 2023 13:50
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2951-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Resolves #2860

Signed-off-by: Andy Scherzinger <[email protected]>
@mahibi mahibi force-pushed the feature/2860/groupMentions branch from b418e17 to 12a9f9b Compare April 19, 2023 10:06
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings109109
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code163163
Internationalization55
Malicious code vulnerability33
Performance1111
Security22
Total193193

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/2951-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit 907012e into master Apr 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/2860/groupMentions branch April 19, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request feature: chat 🗨️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support group mentions

3 participants