Extend mimetypes for direct editing #1778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/1709/extend-mimetypes-direct-editing
branch
from
a30021e to
45e0393
Compare
juliusknorr
reviewed
Jul 19, 2021
Comment on lines
+87
to
+107
| 'application/cmd', | ||
| 'application/x-empty', | ||
| 'application/x-msdos-program', | ||
| 'application/javascript', | ||
| 'application/json', | ||
| 'application/x-perl', | ||
| 'application/x-php', | ||
| 'application/x-tex', | ||
| 'application/xml', | ||
| 'application/yaml', | ||
| 'text/css', | ||
| 'text/csv', | ||
| 'text/html', | ||
| 'text/org', | ||
| 'text/x-c', | ||
| 'text/x-c++src', | ||
| 'text/x-h', | ||
| 'text/x-java-source', | ||
| 'text/x-ldif', | ||
| 'text/x-python', | ||
| 'text/x-shellscript', |
Member
There was a problem hiding this comment.
Not sure if we should rather move those to be the optional opener for direct editing. I assume a local code editor would be more suitable for mobile editing if present.
@tobiasKaminsky What is the behavior on mobile if there is no local editor, would it fall back to the optional ones then or are those really only used through the context menu options?
Member
There was a problem hiding this comment.
We do not differentiate between optional and normal ones, if there is no local app.
if there is a local app and file is downloaded, it is used.
Contributor
Author
|
/rebase |
Signed-off-by: szaimen <[email protected]>
github-actions
bot
force-pushed
the
enh/1709/extend-mimetypes-direct-editing
branch
from
45e0393 to
8cdb2d2
Compare
juliusknorr
approved these changes
Jul 20, 2021
szaimen
added
bug
Contributor
Author
|
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1709
Signed-off-by: szaimen [email protected]