Skip to content

Extend mimetypes for direct editing #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusknorr merged 1 commit into from
Jul 20, 2021
Merged

Extend mimetypes for direct editing #1778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion lib/DirectEditing/TextDirectEditor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,28 @@ public function getName(): string {
public function getMimetypes(): array {
return [
'text/markdown',
'text/plain'
'text/plain',
'application/cmd',
'application/x-empty',
'application/x-msdos-program',
'application/javascript',
'application/json',
'application/x-perl',
'application/x-php',
'application/x-tex',
'application/xml',
'application/yaml',
'text/css',
'text/csv',
'text/html',
'text/org',
'text/x-c',
'text/x-c++src',
'text/x-h',
'text/x-java-source',
'text/x-ldif',
'text/x-python',
'text/x-shellscript',
Comment on lines +87 to +107
Copy link
Member

@juliusknorr juliusknorr Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should rather move those to be the optional opener for direct editing. I assume a local code editor would be more suitable for mobile editing if present.

@tobiasKaminsky What is the behavior on mobile if there is no local editor, would it fall back to the optional ones then or are those really only used through the context menu options?

Copy link
Member

@tobiasKaminsky tobiasKaminsky Jul 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not differentiate between optional and normal ones, if there is no local app.
if there is a local app and file is downloaded, it is used.

];
}

Expand Down