Update mark input/paste rules to tiptap v2 regular expressions #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
force-pushed
the
enh/update_mark_regexps
branch
from
26217f1 to
ad88bf1
Compare
mejo-
force-pushed
the
enh/update_mark_regexps
branch
from
ad88bf1 to
6b980af
Compare
julien-nc
approved these changes
Nov 26, 2021
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
This is nice!
It feels a bit weird when you want a sub part of a word to be bold. You type un**cann**y and it does not get formatted...
But I guess this is a very uncommon use case.
juliusknorr
approved these changes
Nov 26, 2021
mejo-
force-pushed
the
enh/update_mark_regexps
branch
from
6b980af to
a2338f9
Compare
The most important change is that a mark is added only if you are at the beginning of a block or there is a space before it. This especially fixes accidently formatting parts of a string as italic when it contains two underscores (often true in URLs or emoji names). This change can be reverted when we migrated to tiptap v2, but it's a low hanging fix for an annoying bug, and the tiptap v2 migration might take a bit longer. See Philipp Kuehns comment at https://discuss.prosemirror.net/t/4230/3. Signed-off-by: Jonas Meurer <[email protected]>
mejo-
force-pushed
the
enh/update_mark_regexps
branch
from
a2338f9 to
dc436d3
Compare
Member
Author
|
This probably should also be backported to stable23 and stable22 at least, no? @juliushaertl |
Member
|
Yes, definitely. |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
|
The backport to stable22 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most important change is that a mark is added only if you are at
the beginning of a block or there is a space before it.
This especially fixes accidently formatting parts of a string as italic
when it contains two underscores (often true in URLs or emoji names).
This change can be reverted when we migrated to tiptap v2, but it's
a low hanging fix for an annoying bug, and the tiptap v2 migration might
take a bit longer.
See Philipp Kuehns comment at https://discuss.prosemirror.net/t/4230/3.