fix: cypress login with new session feature #2039
Conversation
Use the new session feature to create and reuse sessions: https://docs.cypress.io/api/commands/session The first time `login` with a given name is called the steps described in the login function are performed and cookies and localstorage are cached. The next time `login` is called with the same name cookies and localStorage are restored and used again. This allows us to keep fast test runs while still separating the tests more cleanly. The old logout command was broken because of the way we used `Cypress.Cookies.defaults({ preserve })` before: Cypress runs all the `cy.*` commands during initialization and builds a list of commands that are then executed during the tests. However `Cypress.Cookies.defaults` is evaluated when preparing the list not while performing the actual steps. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
cypress/login-with-sessions
branch
2 times, most recently
from
fd51a2a to
448df55
Compare
Open the test.md file once and then check all the things. Signed-off-by: Azul <[email protected]>
azul
force-pushed
the
cypress/login-with-sessions
branch
from
448df55 to
02cfe27
Compare
|
I think this is the cleanest way and would be a good basis for implementing more complex tests with cypress. However since it's only available since 8.2.0 we can only backport it to I'm currently working on #2020 and i want to prevent regressions like this in the future. Cypress tests seem to be the best way to ensure we don't break things over and over again to me. However if they are very destinct for old branches and the current one backporting the tests adds yet more maintainance overhead. |
|
Very nice, that is a lot cleaner 👏 I think we could also just bump cypress on the stable branches |
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Nice, indeed much cleaner than before :)
|
/backport to stable23 |
|
/backport to stable22 |
Use the new session feature to create and reuse sessions:
https://docs.cypress.io/api/commands/session
The first time
loginwith a given name is calledthe steps described in the login function are performed
and cookies and localstorage are cached.
The next time
loginis called with the same namecookies and localStorage are restored and used again.
This allows us to keep fast test runs
while still separating the tests more cleanly.
The old logout command was broken because of the way
we used
Cypress.Cookies.defaults({ preserve })before:Cypress runs all the
cy.*commands during initializationand builds a list of commands that are then executed during the tests.
However
Cypress.Cookies.defaultsis evaluated when preparing the listnot while performing the actual steps.
Signed-off-by: Azul [email protected]