fix: 2020 let heading menu overflow workspace #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azul
force-pushed
the
fix/2020-heading-menu
branch
from
ec1ac8c to
7bf2a1b
Compare
Contributor
Author
|
I would like to backport this to stable22 and stable23. |
azul
force-pushed
the
fix/2020-heading-menu
branch
2 times, most recently
from
d52a345 to
f8a604a
Compare
azul
force-pushed
the
fix/2020-heading-menu
branch
from
f8a604a to
80e0b8e
Compare
julien-nc
force-pushed
the
fix/2020-heading-menu
branch
from
80e0b8e to
b1157a8
Compare
Member
|
@azul I hope you don't mind, I edited your commits to be able to rebase and compiled again in your last commit. |
* roll back parts of #1903 that broke it again. * Calculate top of menububble based on scrollHeight of content-wrapper. * Always display menububble below selected line. This will make it less likely to conflict with the menubar or mobile copy and paste toolbars. * Add cypress tests for the workspace. Signed-off-by: Azul <[email protected]>
Signed-off-by: Azul <[email protected]> Signed-off-by: Julien Veyssier <[email protected]>
julien-nc
force-pushed
the
fix/2020-heading-menu
branch
from
b1157a8 to
2b73d23
Compare
Collaborator
|
/backport stable23 |
Collaborator
|
/backport stable22 |
Collaborator
|
Will need to backport this next week. |
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roll back parts of Position menububble relative to content-wrapper #1903 that broke it again.
Calculate top of menububble based on scrollHeight of content-wrapper.
Always display menububble below selected line.
This will make it less likely to conflict with the menubar
or mobile copy and paste toolbars.
Add cypress tests for the workspace.
Resolves: Heading menu is getting cut off again #2020
Target version: master