[stable23] fix: 2020 let heading menu overflow workspace #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* roll back parts of #1903 that broke it again. * Calculate top of menububble based on scrollHeight of content-wrapper. * Always display menububble below selected line. This will make it less likely to conflict with the menubar or mobile copy and paste toolbars. * Add cypress tests for the workspace. Signed-off-by: Azul <[email protected]>
Signed-off-by: Azul <[email protected]> Signed-off-by: Julien Veyssier <[email protected]>
* Fixes #2103. * Targets master. Signed-off-by: Max <[email protected]>
max-nextcloud
requested review from
julien-nc and
mejo-
and removed request for
mejo-
Cypress 8.7 was picky about clicking elements that were only halve visible such as the heading h1 menu button after adding a heading Signed-off-by: Max <[email protected]>
Collaborator
Author
|
/backport to stable22 |
mejo-
approved these changes
Jan 18, 2022
|
The backport to stable22 failed. Please do this backport manually. |
This was referenced Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
scrollHeightofcontent-wrapper.This will make it less likely to conflict with the menubar
or mobile copy and paste toolbars.