Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented May 27, 2022

Summary

Add the ability to create links to directories from within the
link menu bubble.

Add the ability to create links to directories from within the
link menu bubble.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels May 30, 2022
@juliusknorr juliusknorr added this to the Nextcloud 25 milestone May 30, 2022
Copy link
Member

@vinicius73 vinicius73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, thanks.

We just need to change the text from bubble menu, to something like "Link file or folder" (what do you think @juliushaertl, @nimishavijay and @jancborchardt ?)

<span class="menububble__buttontext">{{ t('text', 'Link file') }}</span>

And create some cypress tests for it @susnux

@jancborchardt
Copy link
Member

Yup @vinicius73, the same button would work for files or folders, so wording change would be good. :)

@susnux
Copy link
Contributor Author

susnux commented Jun 1, 2022

We just need to change the text from bubble menu, to something like "Link file or folder" (what do you think @juliushaertl, @nimishavijay and @jancborchardt ?)

ok!

And create some cypress tests for it @susnux

Will do that, but first I have to figure out why cypress is not working for me with nextcloud/text...
Edit: Found the reason: Cypress has to run by npm so the correct env variables (in this case npm_package_name is set). So the make target did not work and I had to add a package script.

Details
**Message:** Your `pluginsFile` is invalid: `/var/lib/docker/volumes/nextcloud/_data/apps/text/cypress/plugins/index.js`

It threw an error when required, check the stack trace below:

**Details:** TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:371:5)
    at validateString (node:internal/validators:120:11)
    at Object.join (node:path:1172:7)
    at Object.<anonymous> (/var/lib/docker/volumes/nextcloud/_data/apps/text/node_modules/@nextcloud/webpack-vue-config/webpack.config.js:48:20)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/var/lib/docker/volumes/nextcloud/_data/apps/text/node_modules/@nextcloud/webpack-vue-config/index.js:23:18)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/var/lib/docker/volumes/nextcloud/_data/apps/text/cypress/plugins/index.js:16:24)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at runPlugins (/root/.cache/Cypress/9.7.0/Cypress/resources/app/packages/server/lib/plugins/child/run_plugins.js:186:15)
    at Object.<anonymous> (/root/.cache/Cypress/9.7.0/Cypress/resources/app/packages/server/lib/plugins/child/index.js:8:25)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)

Edit 2: Looks like the scripts for local cypress tests do not work as they create a quite outdated version of nextcloud (docker), so I modified them to create a similar image as the one used by the github CI, see #2481

@susnux
Copy link
Contributor Author

susnux commented Jun 7, 2022

@juliushaertl could you please reopen this?

@juliusknorr
Copy link
Member

@susnux Seems GitHub automation went wild here. It also won't let me reopen it for some reason.

Maybe you can open a new pull request from your branch?

@susnux
Copy link
Contributor Author

susnux commented Jun 20, 2022

@susnux Maybe you can open a new pull request from your branch?

Merged this feature together with the removal of the menububble (to make testing it easier) in the new PR #2519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow linking to folders

4 participants