-
Notifications
You must be signed in to change notification settings - Fork 109
Feature: Allow linking to directories #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add the ability to create links to directories from within the link menu bubble. Signed-off-by: Ferdinand Thiessen <[email protected]>
vinicius73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, thanks.
We just need to change the text from bubble menu, to something like "Link file or folder" (what do you think @juliushaertl, @nimishavijay and @jancborchardt ?)
text/src/components/MenuBubble.vue
Line 60 in f78cee3
| <span class="menububble__buttontext">{{ t('text', 'Link file') }}</span> |
And create some cypress tests for it @susnux
|
Yup @vinicius73, the same button would work for files or folders, so wording change would be good. :) |
ok!
Will do that, DetailsEdit 2: Looks like the scripts for local cypress tests do not work as they create a quite outdated version of nextcloud (docker), so I modified them to create a similar image as the one used by the github CI, see #2481 |
|
@juliushaertl could you please reopen this? |
|
@susnux Seems GitHub automation went wild here. It also won't let me reopen it for some reason. Maybe you can open a new pull request from your branch? |
Summary
Add the ability to create links to directories from within the
link menu bubble.