-
Notifications
You must be signed in to change notification settings - Fork 109
Fix cypress scripts for local run + Add documentation #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix the scripts for local cypress runs, they need to be run within the `npm run` environment, as the nextcloud webpack config requires the `npm_package_name` variable to be set. Also a up-to-date nextcloud instance is required for testing text at the current git head, so updated the dockerfile and docker-compose files to create a nextcloud image from current git head. Additionally updated the tests to use cypress 10.x and added missing documentation on how to run the cypress tests. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
|
Thanks a lot for this @susnux
|
Looks good, it's only important to mount into custom apps, because docker will otherwise remove your current directory (or more precisely the nextcloud entry point) |
juliusknorr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks for documenting those parts and the improvements :)
Have you tried it? For me it works the first time but then stops working |
|
Very strange @susnux |
|
@vinicius73 Not sure why but the Fails reproducible with a fresh system e.g. |
Summary
Fix the scripts for local cypress runs,
they need to be run within the
npm runenvironment,as the nextcloud webpack config requires the
npm_package_namevariable to be set.
Also a up-to-date nextcloud instance is required for testing
text at the current git head, so updated the dockerfile
and docker-compose files to create a nextcloud image from current git head.
(To get it work I modified the docker part to create a similar image as the one used by the github CI)
Additionally updated the tests to use cypress 10.x and
added missing documentation on how to run the cypress tests.